weird loop in s3_lib.c

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

weird loop in s3_lib.c

Michael Richardson

in
        const SSL_CIPHER *ssl3_choose_cipher(SSL *s, STACK_OF(SSL_CIPHER) *clnt,
                                     STACK_OF(SSL_CIPHER) *srvr)


we have:

    for (i = 0; i < sk_SSL_CIPHER_num(prio); i++) {
        c = sk_SSL_CIPHER_value(prio, i);
        ...

            if (!ok)
                continue;
        }


The if (!ok) continue;
is just a no-op.  Maybe it said at some point:
      "if(ok) break;"

which would have an affect, or maybe there was some code after it that was
removed.

--
]               Never tell me the odds!                 | ipv6 mesh networks [
]   Michael Richardson, Sandelman Software Works        | network architect  [
]     [hidden email]  http://www.sandelman.ca/        |   ruby on rails    [


--
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: weird loop in s3_lib.c

Michael Richardson

Michael Richardson <[hidden email]> wrote:
    > in
    > const SSL_CIPHER *ssl3_choose_cipher(SSL *s, STACK_OF(SSL_CIPHER) *clnt,
    > STACK_OF(SSL_CIPHER) *srvr)

never mind.
I mis-read the brackets.

--
]               Never tell me the odds!                 | ipv6 mesh networks [
]   Michael Richardson, Sandelman Software Works        | network architect  [
]     [hidden email]  http://www.sandelman.ca/        |   ruby on rails    [


--
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

signature.asc (497 bytes) Download Attachment