[openssl.org #3342] coverity issue 966577

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[openssl.org #3342] coverity issue 966577

Rich Salz via RT
966577 Resource leak
--------------------

The system resource will not be reclaimed and reused, reducing the future
availability of the resource.

In init_client_ip: Leak of memory or pointers to system resources

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [openssl.org #3342] coverity issue 966577

Marcus Meissner
On Mon, May 05, 2014 at 02:00:32AM +0200, Tim Hudson via RT wrote:
> 966577 Resource leak
> --------------------
>
> The system resource will not be reclaimed and reused, reducing the future
> availability of the resource.
>
> In init_client_ip: Leak of memory or pointers to system resources

This is not helpful without more information, or a patch.

Ciao, Marcus
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [openssl.org #3342] coverity issue 966577

Tim Hudson
On 5/05/2014 6:04 PM, Marcus Meissner wrote:
> On Mon, May 05, 2014 at 02:00:32AM +0200, Tim Hudson via RT wrote:
>> 966577 Resource leak
>> --------------------
>>
>> The system resource will not be reclaimed and reused, reducing the future
>> availability of the resource.
>>
>> In init_client_ip: Leak of memory or pointers to system resources
> This is not helpful without more information, or a patch.

The patch is contained in a git pull request against the public github
repository.
I elected to not have separate messages sent out when adding in the git
pull request - which is in a branch with the RT name against it - this
makes any comments or suggested updates or variations on a patch able to
be discussed openly and also makes the patch able to be easily applied
if you are maintaining your own git tree.

See https://github.com/openssl/openssl/pulls

The specific pull request is noted at
https://rt.openssl.org/Ticket/Display.html?id=3342

And it is https://github.com/openssl/openssl/pull/100

Or to look at the actual patch directly see
https://github.com/openssl/openssl/pull/100/files

This is a simple addition of closesocket() calls in the error path
handling in apps/s_socket.c ...

You will see four PR's (and corresponding patches) for coverity detected
issues ...

Tim.

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]