[openssl.org #1907] openssl-1.0.0-beta1 and -beta2 win32 build problem

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[openssl.org #1907] openssl-1.0.0-beta1 and -beta2 win32 build problem

Rich Salz via RT
Hi,

The non-assembler VC-WIN32 build files don't seem to be working in
1.0.0-beta1 and -beta2. It all works fine on 0.9.8k.

Despite using ms\do_ms.bat instead of ms\do_nasm.bat the makefiles
(ms\nt.mak and ms\ntdll.mak) still try to build the .asm files. I
managed to get it to build (apart from a minor change to a source file -
see below) by changing the VC-WIN32 line in the Configure script - I
changed ${x86_asm} to ${no_asm}. I have no idea if that's a valid change
or not.

The source file I changed is ssl\d1_both.c. The compiler was giving an
"integral size mismatch in argument" warning at line 973. I changed the
code (apologies for formatting) from:

if ( dtls1_retransmit_message(s,
    dtls1_get_queue_priority(frag->msg_header.seq,
    frag->msg_header.is_ccs),
    0, &found) <= 0 && found)

to:

if ( dtls1_retransmit_message(s,
    (unsigned short)dtls1_get_queue_priority(frag->msg_header.seq,
    frag->msg_header.is_ccs),
    0, &found) <= 0 && found)

and it now builds fine. I guess that's not a correct fix and someone
should look at the integer types involved here.

--
Tim

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]