[openssl.org #1894] [patch] typos / linguistic bugs in docs/comments

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[openssl.org #1894] [patch] typos / linguistic bugs in docs/comments

Rich Salz via RT
Simple stuff, but best to get this out of the way finally.

Patch file included, of course.

--
Met vriendelijke groeten / Best regards,

Ger Hobbelt

--------------------------------------------------
web:    http://www.hobbelt.com/
        http://www.hebbut.net/
mail:   [hidden email]
mobile: +31-6-11 120 978
--------------------------------------------------


diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/apps/cms.c ./apps/cms.c
--- /home/ger/prj/1original/openssl/openssl/apps/cms.c 2008-07-13 16:25:34.000000000 +0200
+++ ./apps/cms.c 2009-04-07 09:41:40.000000000 +0200
@@ -704,7 +704,7 @@
 
  if (secret_key && !secret_keyid)
  {
- BIO_printf(bio_err, "No sectre key id\n");
+ BIO_printf(bio_err, "No secret key id\n");
  goto end;
  }
 
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/apps/s_server.c ./apps/s_server.c
--- /home/ger/prj/1original/openssl/openssl/apps/s_server.c 2008-12-20 18:04:37.000000000 +0100
+++ ./apps/s_server.c 2009-04-09 09:18:10.000000000 +0200
@@ -671,7 +671,7 @@
  return p->extension_error;
  if (ctx2)
  {
- BIO_printf(p->biodebug,"Swiching server context.\n");
+ BIO_printf(p->biodebug,"Switching server context.\n");
  SSL_set_SSL_CTX(s,ctx2);
  }    
  }
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/CHANGES.SSLeay ./CHANGES.SSLeay
--- /home/ger/prj/1original/openssl/openssl/CHANGES.SSLeay 1998-12-23 08:42:26.000000000 +0100
+++ ./CHANGES.SSLeay 2009-04-07 10:58:16.000000000 +0200
@@ -148,7 +148,7 @@
       This would tend to cause memory overwrites since SSLv3 has
       a maximum packet size of 16k.  If your program uses
       buffers <= 16k, you would probably never see this problem.
-    - Fixed a new errors that were cause by malloc() not returning
+    - Fixed a few errors that were cause by malloc() not returning
       0 initialised memory..
     - SSL_OP_NETSCAPE_CA_DN_BUG was being switched on when using
       SSL_CTX_set_options(ssl_ctx,SSL_OP_ALL); which was a bad thing
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/crypto/cryptlib.c ./crypto/cryptlib.c
--- /home/ger/prj/1original/openssl/openssl/crypto/cryptlib.c 2008-10-14 17:44:14.000000000 +0200
+++ ./crypto/cryptlib.c 2009-04-07 10:08:47.000000000 +0200
@@ -205,7 +205,7 @@
 #if defined(OPENSSL_SYS_WIN32) || defined(OPENSSL_SYS_WIN16)
  /* A hack to make Visual C++ 5.0 work correctly when linking as
  * a DLL using /MT. Without this, the application cannot use
- * and floating point printf's.
+ * any floating point printf's.
  * It also seems to be needed for Visual C 1.5 (win16) */
  SSLeay_MSVC5_hack=(double)name[0]*(double)name[1];
 #endif
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/crypto/mem_dbg.c ./crypto/mem_dbg.c
--- /home/ger/prj/1original/openssl/openssl/crypto/mem_dbg.c 2009-01-11 21:36:50.000000000 +0100
+++ ./crypto/mem_dbg.c 2009-04-07 10:14:23.000000000 +0200
@@ -787,7 +787,7 @@
  * XXX    This should be in CRYPTO_mem_leaks_cb,
  * and CRYPTO_mem_leaks should be implemented by
  * using CRYPTO_mem_leaks_cb.
- * (Also their should be a variant of lh_doall_arg
+ * (Also there should be a variant of lh_doall_arg
  * that takes a function pointer instead of a void *;
  * this would obviate the ugly and illegal
  * void_fn_to_char kludge in CRYPTO_mem_leaks_cb.
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/crypto/symhacks.h ./crypto/symhacks.h
--- /home/ger/prj/1original/openssl/openssl/crypto/symhacks.h 2008-12-16 11:54:53.000000000 +0100
+++ ./crypto/symhacks.h 2009-04-07 10:17:04.000000000 +0200
@@ -382,7 +382,7 @@
 #endif /* defined OPENSSL_SYS_VMS */
 
 
-/* Case insensiteve linking causes problems.... */
+/* Case insensitive linking causes problems.... */
 #if defined(OPENSSL_SYS_VMS) || defined(OPENSSL_SYS_OS2)
 #undef ERR_load_CRYPTO_strings
 #define ERR_load_CRYPTO_strings ERR_load_CRYPTOlib_strings
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/crypto/x509v3/v3_crld.c ./crypto/x509v3/v3_crld.c
--- /home/ger/prj/1original/openssl/openssl/crypto/x509v3/v3_crld.c 2008-11-05 19:39:05.000000000 +0100
+++ ./crypto/x509v3/v3_crld.c 2009-04-07 11:11:06.000000000 +0200
@@ -152,7 +152,7 @@
  sk_X509_NAME_ENTRY_num(rnm) - 1)->set)
  {
  X509V3err(X509V3_F_SET_DIST_POINT_NAME,
- X509V3_R_INVAID_MULTIPLE_RDNS);
+ X509V3_R_INVALID_MULTIPLE_RDNS);
  goto err;
  }
  }
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/crypto/x509v3/v3_pci.c ./crypto/x509v3/v3_pci.c
--- /home/ger/prj/1original/openssl/openssl/crypto/x509v3/v3_pci.c 2007-03-05 01:09:08.000000000 +0100
+++ ./crypto/x509v3/v3_pci.c 2009-04-07 11:12:12.000000000 +0200
@@ -82,7 +82,7 @@
  {
  if (*language)
  {
- X509V3err(X509V3_F_PROCESS_PCI_VALUE,X509V3_R_POLICY_LANGUAGE_ALREADTY_DEFINED);
+ X509V3err(X509V3_F_PROCESS_PCI_VALUE,X509V3_R_POLICY_LANGUAGE_ALREADY_DEFINED);
  X509V3_conf_err(val);
  return 0;
  }
@@ -97,7 +97,7 @@
  {
  if (*pathlen)
  {
- X509V3err(X509V3_F_PROCESS_PCI_VALUE,X509V3_R_POLICY_PATH_LENGTH_ALREADTY_DEFINED);
+ X509V3err(X509V3_F_PROCESS_PCI_VALUE,X509V3_R_POLICY_PATH_LENGTH_ALREADY_DEFINED);
  X509V3_conf_err(val);
  return 0;
  }
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/doc/crypto/BIO_s_mem.pod ./doc/crypto/BIO_s_mem.pod
--- /home/ger/prj/1original/openssl/openssl/doc/crypto/BIO_s_mem.pod 2000-09-16 18:00:22.000000000 +0200
+++ ./doc/crypto/BIO_s_mem.pod 2009-04-07 10:23:28.000000000 +0200
@@ -74,7 +74,7 @@
 their size can grow indefinitely.
 
 Every read from a read write memory BIO will remove the data just read with
-an internal copy operation, if a BIO contains a lots of data and it is
+an internal copy operation, if a BIO contains a lot of data and it is
 read in small chunks the operation can be very slow. The use of a read only
 memory BIO avoids this problem. If the BIO must be read write then adding
 a buffering BIO to the chain will speed up the process.
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/doc/ssleay.txt ./doc/ssleay.txt
--- /home/ger/prj/1original/openssl/openssl/doc/ssleay.txt 2009-02-14 22:49:36.000000000 +0100
+++ ./doc/ssleay.txt 2009-04-07 10:32:15.000000000 +0200
@@ -20,7 +20,7 @@
 ==== readme ========================================================
 
 This is the old 0.6.6 docuementation.  Most of the cipher stuff is still
-relevent but I'm working (very slowly) on new docuemtation.
+relevent but I'm working (very slowly) on new documentation.
 The current version can be found online at
 
 http://www.cryptsoft.com/ssleay/doc
@@ -548,8 +548,8 @@
 can all be compiled independantly.
 
 ssleay has 3 modes of operation.
-1) If the ssleay binaray has the name of one of its component programs, it
-executes that program and then exits.  This can be achieve by using hard or
+1) If the ssleay binary has the name of one of its component programs, it
+executes that program and then exits.  This can be achieved by using hard or
 symbolic links, or failing that, just renaming the binary.
 2) If the first argument to ssleay is the name of one of the component
 programs, that program runs that program and then exits.
@@ -1185,7 +1185,7 @@
  example is for BIO_s_sock().  A socket needs to be
  assigned to the BIO before it can be used.
 - 'shutdown', this flag indicates if the underlying
- comunication primative being used should be closed/freed
+ communication primitive being used should be closed/freed
  when the BIO is closed.
 - 'flags' is used to hold extra state.  It is primarily used
  to hold information about why a non-blocking operation
@@ -1799,7 +1799,7 @@
 
 unsigned long BN_get_word(BIGNUM *a);
  Returns 'a' in an unsigned long.  Not remarkably, often 'a' will
- be biger than a word, in which case 0xffffffffL is returned.
+ be bigger than a word, in which case 0xffffffffL is returned.
 
 Word Operations
 These functions are much more efficient that the normal bignum arithmetic
@@ -2058,7 +2058,7 @@
                 PEM_ASN1_write((int (*)())i2d_X509,PEM_STRING_X509,fp, \
                         (char *)x, NULL,NULL,0,NULL)
 Don't do encryption normally.  If you want to PEM encrypt your X509 structure,
-either just call PEM_ASN1_write directly or just define you own
+either just call PEM_ASN1_write directly or just define your own
 macro variant.  As you can see, this macro just sets all encryption related
 parameters to NULL.
 
@@ -5566,7 +5566,7 @@
 
 The SSL_CTX has a session_cache_mode which is by default,
 in SSL_SESS_CACHE_SERVER mode.  What this means is that the library
-will automatically add new session-id's to the cache apon sucsessful
+will automatically add new session-id's to the cache upon successful
 SSL_accept() calls.
 If SSL_SESS_CACHE_CLIENT is set, then client certificates are also added
 to the cache.
@@ -5580,12 +5580,12 @@
 If SSL_SESS_CACHE_NO_AUTO_CLEAR is set, old timed out sessions are
 not automatically removed each 255, SSL_connect()s or SSL_accept()s.
 
-By default, apon every 255 successful SSL_connect() or SSL_accept()s,
+By default, upon every 255 successful SSL_connect() or SSL_accept()s,
 the cache is flush.  Please note that this could be expensive on
 a heavily loaded SSL server, in which case, turn this off and
 clear the cache of old entries 'manually' (with one of the functions
 listed below) every few hours.  Perhaps I should up this number, it is hard
-to say.  Remember, the '255' new calls is just a mechanims to get called
+to say.  Remember, the '255' new calls is just a mechanism to get called
 every now and then, in theory at most 255 new session-id's will have been
 added but if 100 are added every minute, you would still have
 500 in the cache before any would start being flushed (assuming a 3 minute
@@ -5628,10 +5628,10 @@
 void SSL_CTX_sess_set_get_cb(ctx,cb) sets the callback and
 int (*cb)()SSL_CTX_sess_get_get_cb(ctx) returns the callback.
 
-These callbacks are basically indended to be used by processes to
+These callbacks are basically intended to be used by processes to
 send their session-id's to other processes.  I currently have not implemented
-non-blocking semantics for these callbacks, it is upto the appication
-to make the callbacks effiecent if they require blocking (perhaps
+non-blocking semantics for these callbacks, it is upto the application
+to make the callbacks efficient if they require blocking (perhaps
 by 'saving' them and then 'posting them' when control returns from
 the SSL_accept().
 
@@ -6589,7 +6589,7 @@
 condition has dissapeared.
 
 After the connection has been made, information can be retrived about the
-SSL session and the session-id values that have been decided apon.
+SSL session and the session-id values that have been decided upon.
 The 'peer' certificate can be retrieved.
 
 The session-id values include
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/engines/ccgost/gost94_keyx.c ./engines/ccgost/gost94_keyx.c
--- /home/ger/prj/1original/openssl/openssl/engines/ccgost/gost94_keyx.c 2008-12-13 18:39:53.000000000 +0100
+++ ./engines/ccgost/gost94_keyx.c 2009-04-09 09:23:40.000000000 +0200
@@ -25,7 +25,7 @@
 
 /* Computes Diffie-Hellman key and stores it into buffer in
  * little-endian byte order as expected by both versions of GOST 94
- * algorigthm
+ * algorithm
  */
 static int compute_pair_key_le(unsigned char *pair_key,BIGNUM *pub_key,DH *dh)
  {
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/engines/ccgost/gost_sign.c ./engines/ccgost/gost_sign.c
--- /home/ger/prj/1original/openssl/openssl/engines/ccgost/gost_sign.c 2008-02-28 14:45:06.000000000 +0100
+++ ./engines/ccgost/gost_sign.c 2009-04-07 10:34:07.000000000 +0200
@@ -3,7 +3,7 @@
  *             Copyright (c) 2005-2006 Cryptocom LTD                  *
  *         This file is distributed under the same license as OpenSSL *
  *                                                                    *
- *       Implementation of GOST R 34.10-94 signature algoritgthm      *
+ *       Implementation of GOST R 34.10-94 signature algorithm        *
  *       for OpenSSL                                                  *
  *          Requires OpenSSL 0.9.9 for compilation                    *
  **********************************************************************/
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/e_os2.h ./e_os2.h
--- /home/ger/prj/1original/openssl/openssl/e_os2.h 2007-05-20 22:11:16.000000000 +0200
+++ ./e_os2.h 2009-04-07 11:02:55.000000000 +0200
@@ -262,7 +262,7 @@
 #define OPENSSL_EXTERN OPENSSL_IMPORT
 
 /* Macros to allow global variables to be reached through function calls when
-   required (if a shared library version requvres it, for example.
+   required (if a shared library version requires it, for example.
    The way it's done allows definitions like this:
 
  // in foobar.c
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/e_os.h ./e_os.h
--- /home/ger/prj/1original/openssl/openssl/e_os.h 2008-12-22 14:54:09.000000000 +0100
+++ ./e_os.h 2009-04-07 11:01:07.000000000 +0200
@@ -112,7 +112,7 @@
 /********************************************************************
  The Microsoft section
  ********************************************************************/
-/* The following is used becaue of the small stack in some
+/* The following is used because of the small stack in some
  * Microsoft operating systems */
 #if defined(OPENSSL_SYS_MSDOS) && !defined(OPENSSL_SYSNAME_WIN32)
 #  define MS_STATIC static
@@ -275,14 +275,14 @@
 #    if !defined(OPENSSL_NO_SOCK) && defined(_WIN32_WINNT)
        /*
         * Just like defining _WIN32_WINNT including winsock2.h implies
-        * certain "discipline" for maintaing [broad] binary compatibility.
+        * certain "discipline" for maintaining [broad] binary compatibility.
         * As long as structures are invariant among Winsock versions,
         * it's sufficient to check for specific Winsock2 API availability
         * at run-time [DSO_global_lookup is recommended]...
         */
 #      include <winsock2.h>
 #      include <ws2tcpip.h>
-       /* yes, they have to be #included prior <windows.h> */
+       /* yes, they have to be #included prior to <windows.h> */
 #    endif
 #    include <windows.h>
 #    include <stdio.h>
@@ -372,7 +372,7 @@
 #    define DEFAULT_HOME  "C:"
 #  endif
 
-#else /* The non-microsoft world world */
+#else /* The non-microsoft world */
 
 #  ifdef OPENSSL_SYS_VMS
 #    define VMS 1
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/ms/README ./ms/README
--- /home/ger/prj/1original/openssl/openssl/ms/README 2005-05-17 15:51:34.000000000 +0200
+++ ./ms/README 2009-04-07 10:45:01.000000000 +0200
@@ -4,7 +4,7 @@
 
 The results will be in the out directory.
 
-These makefiles and def files were generated my typing
+These makefiles and def files were generated by typing
 
 perl util\mk1mf.pl VC-NT >ms/nt.mak
 perl util\mk1mf.pl VC-NT dll >ms/ntdll.mak
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/ssl/CVS/Entries ./ssl/CVS/Entries
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/ssl/s3_enc.c ./ssl/s3_enc.c
--- /home/ger/prj/1original/openssl/openssl/ssl/s3_enc.c 2009-04-07 07:33:27.000000000 +0200
+++ ./ssl/s3_enc.c 2009-04-07 10:48:17.000000000 +0200
@@ -655,7 +655,7 @@
  if (!ssl3_digest_cached_records(s))
  return 0;
 
- /* Search for djgest of specified type  in the handshake_dgst
+ /* Search for digest of specified type in the handshake_dgst
  * array*/
  for (i=0;i<SSL_MAX_DIGEST;i++)
  {
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/ssl/s3_pkt.c ./ssl/s3_pkt.c
--- /home/ger/prj/1original/openssl/openssl/ssl/s3_pkt.c 2009-04-09 08:55:58.000000000 +0200
+++ ./ssl/s3_pkt.c 2009-04-09 09:25:38.000000000 +0200
@@ -837,8 +837,7 @@
  }
  else if (i <= 0) {
  if (s->version == DTLS1_VERSION) {
- /* For DTLS, just drop it. That's kind of the wh
-ole
+ /* For DTLS, just drop it. That's kind of the whole
    point in using a datagram service */
  wb->left = 0;
  }
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/test/times ./test/times
--- /home/ger/prj/1original/openssl/openssl/test/times 2009-02-14 22:49:38.000000000 +0100
+++ ./test/times 2009-04-07 10:54:59.000000000 +0200
@@ -1,7 +1,7 @@
 
 More number for the questions about SSL overheads....
 
-The following numbers were generated on a pentium pro 200, running linux.
+The following numbers were generated on a Pentium pro 200, running Linux.
 They give an indication of the SSL protocol and encryption overheads.
 
 The program that generated them is an unreleased version of ssl/ssltest.c
@@ -11,7 +11,7 @@
 
 How do I read this?  The protocol and cipher are reasonable obvious.
 The next number is the number of connections being made.  The next is the
-number of bytes exchanged bewteen the client and server side of the protocol.
+number of bytes exchanged between the client and server side of the protocol.
 This is the number of bytes that the client sends to the server, and then
 the server sends back.  Because this is all happening in one process,
 the data is being encrypted, decrypted, encrypted and then decrypted again.
@@ -55,10 +55,10 @@
 
 What does this all mean?  Well for a server, with no session-id reuse, with
 a transfer size of 10240 bytes, using RC4-MD5 and a 512bit server key,
-a pentium pro 200 running linux can handle the SSLv3 protocol overheads of
+a Pentium pro 200 running Linux can handle the SSLv3 protocol overheads of
 about 49 connections a second.  Reality will be quite different :-).
 
-Remeber the first number is 1000 full ssl handshakes, the second is
+Remember the first number is 1000 full ssl handshakes, the second is
 1 full and 999 with session-id reuse.  The RSA overheads for each exchange
 would be one public and one private operation, but the protocol/MAC/cipher
 cost would be quite similar in both the client and server.
@@ -72,21 +72,21 @@
   killer in SSL.  Often delays in the TCP protocol will make session-id
   reuse look slower that new sessions, but this would not be the case on
   a loaded server.
-- The TCP round trip latencies, while slowing indervidual connections,
+- The TCP round trip latencies, while slowing individual connections,
   would have minimal impact on throughput.
 - Instead of sending one 102400 byte buffer, one 8k buffer is sent until
 - the required number of bytes are processed.
-- The SSLv3 connections were actually SSLv2 compatable SSLv3 headers.
+- The SSLv3 connections were actually SSLv2 compatible SSLv3 headers.
 - A 512bit server key was being used except where noted.
 - No server key verification was being performed on the client side of the
   protocol.  This would slow things down very little.
 - The library being used is SSLeay 0.8.x.
-- The normal mesauring system was commands of the form
+- The normal measuring system was commands of the form
   time ./ssltest -num 1000 -bytes 102400 -cipher DES-CBC-SHA -reuse
   This modified version of ssltest should be in the next public release of
   SSLeay.
 
-The general cipher performace number for this platform are
+The general cipher performance number for this platform are
 
 SSLeay 0.8.2a 04-Sep-1997
 built on Fri Sep  5 17:37:05 EST 1997
diff -u -r -E -b -w -B -d --strip-trailing-cr -I '^[[:blank:]]*};\?[[:blank:]]*$' /home/ger/prj/1original/openssl/openssl/times/x86/des3s.cpp ./times/x86/des3s.cpp
--- /home/ger/prj/1original/openssl/openssl/times/x86/des3s.cpp 1999-04-24 01:28:26.000000000 +0200
+++ ./times/x86/des3s.cpp 2009-04-07 10:55:10.000000000 +0200
@@ -60,7 +60,7 @@
  des_encrypt3(&data[0],key1,key2,key3);
  }
 
- printf("des %d %d (%d)\n",
+ printf("des3 %d %d (%d)\n",
  e1-s1,e2-s2,((e2-s2)-(e1-s1)));
  }
  }
Reply | Threaded
Open this post in threaded view
|

Re: [openssl.org #1894] [patch] typos / linguistic bugs in docs/comments

Ted Mittelstaedt
Ger Hobbelt via RT wrote:
> Simple stuff, but best to get this out of the way finally.
>
> Patch file included, of course.
>
>

Here is a patch to your patch:


+ * any floating point printf's.
+will automatically add new session-id's to the cache upon successful

are supposed to be:

+ * any floating point printfs.
+will automatically add new session-ids to the cache upon successful


plural, not possessive.

Ted
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [openssl.org #1894] [patch] typos / linguistic bugs in docs/comments

Ger Hobbelt
On Thu, Apr 9, 2009 at 6:42 PM, Ted Mittelstaedt <[hidden email]> wrote:
> Here is a patch to your patch:
[...]
> plural, not possessive.

Thanks for the correction. It's appreciated!


[updated patch included]
--
Met vriendelijke groeten / Best regards,

Ger Hobbelt

--------------------------------------------------
web:    http://www.hobbelt.com/
        http://www.hebbut.net/
mail:   [hidden email]
mobile: +31-6-11 120 978
--------------------------------------------------

OpenSSL.20090409.unified.diff (27K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [openssl.org #1894] [patch] typos / linguistic bugs in docs/comments

Steven M. Schweda-2
In reply to this post by Rich Salz via RT
From: Ger Hobbelt <[hidden email]>

> On Thu, Apr 9, 2009 at 6:42 PM, Ted Mittelstaedt <[hidden email]> wrote:
> > Here is a patch to your patch:
> [...]
> > plural, not possessive.
>
> Thanks for the correction. It's appreciated!

   Hey.  Don't give up so easily.  While it's possible to find backing
for almost any opinion involving an apostrophe, a rule like "plural, not
possessive" is much too simple to be reliable.  See, for example:

      http://www.meredith.edu/grammar/plural.htm

      [...]
      Although usage has changed in recent years, some handbooks call
      for an apostrophe in the plural forms of numbers, letters, and
      words used as words:

      How many 1's do we have in the line?
      We put x's on the incorrect answers.
      The no's resounded loudly throughout the chamber.
      [...]

Google can find many more concurring opinions.

   I claim that a C run-time function, like "printf" here, qualifies as
a word used as a word, and so "printf's" is a perfectly reasonable
plural form.  On the other hand, a plural form like "printfs" would be
indistinguisable from a different function, "printfs()", which might
easily exist.  (Is "abs" really "abs()", or is it the plural of "ab()"?
How about "fgets" and "fputs?"?  Better yet, "utime" and "utimes"?

   Everything's complicated.  Trust no one.  Especially not a native
English speaker.  As Count Aristid Karpathy once said, "The English do
not know how to speak their own language.  Only foreigners who have been
taught to speak it speak it well."  The story's about the same for
writing as it is for speaking.

------------------------------------------------------------------------

   Steven M. Schweda               sms@antinode-info
   382 South Warwick Street        (+1) 651-699-9818
   Saint Paul  MN  55105-2547
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [openssl.org #1894] [patch] typos / linguistic bugs in docs/comments

Ger Hobbelt
On Fri, Apr 10, 2009 at 5:03 AM, Steven M. Schweda <[hidden email]> wrote:
>   Hey.  Don't give up so easily.  While it's possible to find backing
> for almost any opinion involving an apostrophe, a rule like "plural, not
> possessive" is much too simple to be reliable.  See, for example:

Ha! :-)))

Well, my Strunk & White (4th ed., 2000 AD) don't say nuttin' about
throwing in an apostrophe here, but, yes, I'm with you. Some of the
way. I have to concede that, yes, I behaved too much like a meek sheep
in this.


Ignoring the fundamental flaw in the entire argument for a moment, the
google output seems overwhelming, yet trusting google democracy / vox
populi, which we all know since Churchill at the very last, is not
really leading the way towards reaching the pinnacle of brainiac
achievement either.

Given the graveness of the issue, I will retire to HQ and ponder this
sorry affair.

A suitable, definite statement to settle the matter will be forthcoming shortly.

--
Met vriendelijke groeten / Best regards,

Ger Hobbelt

--------------------------------------------------
web:    http://www.hobbelt.com/
        http://www.hebbut.net/
mail:   [hidden email]
mobile: +31-6-11 120 978
--------------------------------------------------
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [openssl.org #1894] [patch] typos / linguistic bugs in docs/comments

Kyle Hamilton
printf()s ;)

-Kyle H

On Thu, Apr 9, 2009 at 10:20 PM, Ger Hobbelt <[hidden email]> wrote:

> On Fri, Apr 10, 2009 at 5:03 AM, Steven M. Schweda <[hidden email]> wrote:
>>   Hey.  Don't give up so easily.  While it's possible to find backing
>> for almost any opinion involving an apostrophe, a rule like "plural, not
>> possessive" is much too simple to be reliable.  See, for example:
>
> Ha! :-)))
>
> Well, my Strunk & White (4th ed., 2000 AD) don't say nuttin' about
> throwing in an apostrophe here, but, yes, I'm with you. Some of the
> way. I have to concede that, yes, I behaved too much like a meek sheep
> in this.
>
>
> Ignoring the fundamental flaw in the entire argument for a moment, the
> google output seems overwhelming, yet trusting google democracy / vox
> populi, which we all know since Churchill at the very last, is not
> really leading the way towards reaching the pinnacle of brainiac
> achievement either.
>
> Given the graveness of the issue, I will retire to HQ and ponder this
> sorry affair.
>
> A suitable, definite statement to settle the matter will be forthcoming shortly.
>
> --
> Met vriendelijke groeten / Best regards,
>
> Ger Hobbelt
>
> --------------------------------------------------
> web:    http://www.hobbelt.com/
>        http://www.hebbut.net/
> mail:   [hidden email]
> mobile: +31-6-11 120 978
> --------------------------------------------------
> ______________________________________________________________________
> OpenSSL Project                                 http://www.openssl.org
> Development Mailing List                       [hidden email]
> Automated List Manager                           [hidden email]
>
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [openssl.org #1894] [patch] typos / linguistic bugs in docs/comments

Ted Mittelstaedt
In reply to this post by Steven M. Schweda-2
Steven M. Schweda wrote:

> From: Ger Hobbelt <[hidden email]>
>
>  
>> On Thu, Apr 9, 2009 at 6:42 PM, Ted Mittelstaedt <[hidden email]> wrote:
>>    
>>> Here is a patch to your patch:
>>>      
>> [...]
>>    
>>> plural, not possessive.
>>>      
>> Thanks for the correction. It's appreciated!
>>    
>
>    Hey.  Don't give up so easily.  While it's possible to find backing
> for almost any opinion involving an apostrophe, a rule like "plural, not
> possessive" is much too simple to be reliable.

It wasn't a rule, it was a guideline.

However, the sentence:

"The no's resounded loudly"can be read either as possessive or plural,
although if
your indicating possessive I think the proper thing would be to
capitalize, as such:

"The No's resounded loudly"

Frankly it's a terrible example sentence whatever you mean because if spoken
out loud, it sounds like "nose" as in snot, so the image is of a chamber
full of
people blowing their noses.

The original lines in the patch are a bit different as neither can
really be read as
possessive.

As for "word used as a word" I'll leave you to ponder the
meaninglessness of that
phrase.  It's definitely not in common usage.

However, whatever you end up deciding, it needs to be consistent among
the entire
text - if your going to do this "word used as a word" thing, you better
check the
rest of the text.

>    Everything's complicated.  Trust no one.  Especially not a native
> English speaker.  As Count Aristid Karpathy once said, "The English do
> not know how to speak their own language.  Only foreigners who have been
> taught to speak it speak it well."

Well, nobody has really explained why the shift from "Olde English" ever
happened
with any degree of believability, which is why that joke is apropos.

Ted
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [openssl.org #1894] [patch] typos / linguistic bugs in docs/comments

David Woodhouse-7
In reply to this post by Rich Salz via RT
On Thu, 2009-04-09 at 09:03 +0200, Ger Hobbelt via RT wrote:
> +++ ./crypto/x509v3/v3_crld.c   2009-04-07 11:11:06.000000000 +0200
> @@ -152,7 +152,7 @@
>                                 sk_X509_NAME_ENTRY_num(rnm) - 1)->set)
>                         {
>                         X509V3err(X509V3_F_SET_DIST_POINT_NAME,
> -                                               X509V3_R_INVAID_MULTIPLE_RDNS);
> +                                               X509V3_R_INVALID_MULTIPLE_RDNS);

This makes it compile again (at least, if I don't disable EC and various
other things). When you fix typos like that, you have to fix the
definition too... and then the other user(s).

Index: crypto/x509v3/v3err.c
===================================================================
RCS file: /home/dwmw2/openssl-cvs/openssl/crypto/x509v3/v3err.c,v
retrieving revision 1.41
diff -u -p -r1.41 v3err.c
--- crypto/x509v3/v3err.c 24 Mar 2008 22:14:02 -0000 1.41
+++ crypto/x509v3/v3err.c 19 Apr 2009 17:38:19 -0000
@@ -159,7 +159,7 @@ static ERR_STRING_DATA X509V3_str_reason
 {ERR_REASON(X509V3_R_ILLEGAL_EMPTY_EXTENSION),"illegal empty extension"},
 {ERR_REASON(X509V3_R_ILLEGAL_HEX_DIGIT)  ,"illegal hex digit"},
 {ERR_REASON(X509V3_R_INCORRECT_POLICY_SYNTAX_TAG),"incorrect policy syntax tag"},
-{ERR_REASON(X509V3_R_INVAID_MULTIPLE_RDNS),"invaid multiple rdns"},
+{ERR_REASON(X509V3_R_INVALID_MULTIPLE_RDNS),"invaid multiple rdns"},
 {ERR_REASON(X509V3_R_INVALID_ASNUMBER)   ,"invalid asnumber"},
 {ERR_REASON(X509V3_R_INVALID_ASRANGE)    ,"invalid asrange"},
 {ERR_REASON(X509V3_R_INVALID_BOOLEAN_STRING),"invalid boolean string"},
@@ -193,9 +193,9 @@ static ERR_STRING_DATA X509V3_str_reason
 {ERR_REASON(X509V3_R_ODD_NUMBER_OF_DIGITS),"odd number of digits"},
 {ERR_REASON(X509V3_R_OPERATION_NOT_DEFINED),"operation not defined"},
 {ERR_REASON(X509V3_R_OTHERNAME_ERROR)    ,"othername error"},
-{ERR_REASON(X509V3_R_POLICY_LANGUAGE_ALREADTY_DEFINED),"policy language alreadty defined"},
+{ERR_REASON(X509V3_R_POLICY_LANGUAGE_ALREADY_DEFINED),"policy language alreadty defined"},
 {ERR_REASON(X509V3_R_POLICY_PATH_LENGTH) ,"policy path length"},
-{ERR_REASON(X509V3_R_POLICY_PATH_LENGTH_ALREADTY_DEFINED),"policy path length alreadty defined"},
+{ERR_REASON(X509V3_R_POLICY_PATH_LENGTH_ALREADY_DEFINED),"policy path length alreadty defined"},
 {ERR_REASON(X509V3_R_POLICY_SYNTAX_NOT_CURRENTLY_SUPPORTED),"policy syntax not currently supported"},
 {ERR_REASON(X509V3_R_POLICY_WHEN_PROXY_LANGUAGE_REQUIRES_NO_POLICY),"policy when proxy language requires no policy"},
 {ERR_REASON(X509V3_R_SECTION_NOT_FOUND)  ,"section not found"},
Index: crypto/x509v3/x509v3.h
===================================================================
RCS file: /home/dwmw2/openssl-cvs/openssl/crypto/x509v3/x509v3.h,v
retrieving revision 1.126
diff -u -p -r1.126 x509v3.h
--- crypto/x509v3/x509v3.h 5 Nov 2008 18:39:05 -0000 1.126
+++ crypto/x509v3/x509v3.h 19 Apr 2009 17:38:24 -0000
@@ -951,7 +951,7 @@ void ERR_load_X509V3_strings(void);
 #define X509V3_R_ILLEGAL_EMPTY_EXTENSION 151
 #define X509V3_R_ILLEGAL_HEX_DIGIT 113
 #define X509V3_R_INCORRECT_POLICY_SYNTAX_TAG 152
-#define X509V3_R_INVAID_MULTIPLE_RDNS 161
+#define X509V3_R_INVALID_MULTIPLE_RDNS 161
 #define X509V3_R_INVALID_ASNUMBER 162
 #define X509V3_R_INVALID_ASRANGE 163
 #define X509V3_R_INVALID_BOOLEAN_STRING 104
@@ -985,9 +985,9 @@ void ERR_load_X509V3_strings(void);
 #define X509V3_R_ODD_NUMBER_OF_DIGITS 112
 #define X509V3_R_OPERATION_NOT_DEFINED 148
 #define X509V3_R_OTHERNAME_ERROR 147
-#define X509V3_R_POLICY_LANGUAGE_ALREADTY_DEFINED 155
+#define X509V3_R_POLICY_LANGUAGE_ALREADY_DEFINED 155
 #define X509V3_R_POLICY_PATH_LENGTH 156
-#define X509V3_R_POLICY_PATH_LENGTH_ALREADTY_DEFINED 157
+#define X509V3_R_POLICY_PATH_LENGTH_ALREADY_DEFINED 157
 #define X509V3_R_POLICY_SYNTAX_NOT_CURRENTLY_SUPPORTED 158
 #define X509V3_R_POLICY_WHEN_PROXY_LANGUAGE_REQUIRES_NO_POLICY 159
 #define X509V3_R_SECTION_NOT_FOUND 150


--
dwmw2

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [openssl.org #1894] [patch] typos / linguistic bugs in docs/comments

Rich Salz via RT
On Thu, 2009-04-09 at 09:03 +0200, Ger Hobbelt via RT wrote:
> +++ ./crypto/x509v3/v3_crld.c   2009-04-07 11:11:06.000000000 +0200
> @@ -152,7 +152,7 @@
>                                 sk_X509_NAME_ENTRY_num(rnm) - 1)->set)
>                         {
>                         X509V3err(X509V3_F_SET_DIST_POINT_NAME,
> -                                               X509V3_R_INVAID_MULTIPLE_RDNS);
> +                                               X509V3_R_INVALID_MULTIPLE_RDNS);

This makes it compile again (at least, if I don't disable EC and various
other things). When you fix typos like that, you have to fix the
definition too... and then the other user(s).

Index: crypto/x509v3/v3err.c
===================================================================
RCS file: /home/dwmw2/openssl-cvs/openssl/crypto/x509v3/v3err.c,v
retrieving revision 1.41
diff -u -p -r1.41 v3err.c
--- crypto/x509v3/v3err.c 24 Mar 2008 22:14:02 -0000 1.41
+++ crypto/x509v3/v3err.c 19 Apr 2009 17:38:19 -0000
@@ -159,7 +159,7 @@ static ERR_STRING_DATA X509V3_str_reason
 {ERR_REASON(X509V3_R_ILLEGAL_EMPTY_EXTENSION),"illegal empty extension"},
 {ERR_REASON(X509V3_R_ILLEGAL_HEX_DIGIT)  ,"illegal hex digit"},
 {ERR_REASON(X509V3_R_INCORRECT_POLICY_SYNTAX_TAG),"incorrect policy syntax tag"},
-{ERR_REASON(X509V3_R_INVAID_MULTIPLE_RDNS),"invaid multiple rdns"},
+{ERR_REASON(X509V3_R_INVALID_MULTIPLE_RDNS),"invaid multiple rdns"},
 {ERR_REASON(X509V3_R_INVALID_ASNUMBER)   ,"invalid asnumber"},
 {ERR_REASON(X509V3_R_INVALID_ASRANGE)    ,"invalid asrange"},
 {ERR_REASON(X509V3_R_INVALID_BOOLEAN_STRING),"invalid boolean string"},
@@ -193,9 +193,9 @@ static ERR_STRING_DATA X509V3_str_reason
 {ERR_REASON(X509V3_R_ODD_NUMBER_OF_DIGITS),"odd number of digits"},
 {ERR_REASON(X509V3_R_OPERATION_NOT_DEFINED),"operation not defined"},
 {ERR_REASON(X509V3_R_OTHERNAME_ERROR)    ,"othername error"},
-{ERR_REASON(X509V3_R_POLICY_LANGUAGE_ALREADTY_DEFINED),"policy language alreadty defined"},
+{ERR_REASON(X509V3_R_POLICY_LANGUAGE_ALREADY_DEFINED),"policy language alreadty defined"},
 {ERR_REASON(X509V3_R_POLICY_PATH_LENGTH) ,"policy path length"},
-{ERR_REASON(X509V3_R_POLICY_PATH_LENGTH_ALREADTY_DEFINED),"policy path length alreadty defined"},
+{ERR_REASON(X509V3_R_POLICY_PATH_LENGTH_ALREADY_DEFINED),"policy path length alreadty defined"},
 {ERR_REASON(X509V3_R_POLICY_SYNTAX_NOT_CURRENTLY_SUPPORTED),"policy syntax not currently supported"},
 {ERR_REASON(X509V3_R_POLICY_WHEN_PROXY_LANGUAGE_REQUIRES_NO_POLICY),"policy when proxy language requires no policy"},
 {ERR_REASON(X509V3_R_SECTION_NOT_FOUND)  ,"section not found"},
Index: crypto/x509v3/x509v3.h
===================================================================
RCS file: /home/dwmw2/openssl-cvs/openssl/crypto/x509v3/x509v3.h,v
retrieving revision 1.126
diff -u -p -r1.126 x509v3.h
--- crypto/x509v3/x509v3.h 5 Nov 2008 18:39:05 -0000 1.126
+++ crypto/x509v3/x509v3.h 19 Apr 2009 17:38:24 -0000
@@ -951,7 +951,7 @@ void ERR_load_X509V3_strings(void);
 #define X509V3_R_ILLEGAL_EMPTY_EXTENSION 151
 #define X509V3_R_ILLEGAL_HEX_DIGIT 113
 #define X509V3_R_INCORRECT_POLICY_SYNTAX_TAG 152
-#define X509V3_R_INVAID_MULTIPLE_RDNS 161
+#define X509V3_R_INVALID_MULTIPLE_RDNS 161
 #define X509V3_R_INVALID_ASNUMBER 162
 #define X509V3_R_INVALID_ASRANGE 163
 #define X509V3_R_INVALID_BOOLEAN_STRING 104
@@ -985,9 +985,9 @@ void ERR_load_X509V3_strings(void);
 #define X509V3_R_ODD_NUMBER_OF_DIGITS 112
 #define X509V3_R_OPERATION_NOT_DEFINED 148
 #define X509V3_R_OTHERNAME_ERROR 147
-#define X509V3_R_POLICY_LANGUAGE_ALREADTY_DEFINED 155
+#define X509V3_R_POLICY_LANGUAGE_ALREADY_DEFINED 155
 #define X509V3_R_POLICY_PATH_LENGTH 156
-#define X509V3_R_POLICY_PATH_LENGTH_ALREADTY_DEFINED 157
+#define X509V3_R_POLICY_PATH_LENGTH_ALREADY_DEFINED 157
 #define X509V3_R_POLICY_SYNTAX_NOT_CURRENTLY_SUPPORTED 158
 #define X509V3_R_POLICY_WHEN_PROXY_LANGUAGE_REQUIRES_NO_POLICY 159
 #define X509V3_R_SECTION_NOT_FOUND 150


--
dwmw2


______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]