Re: [PATCH] crypto/ui/ui_openssl.c: let new-line through after query in Windows path.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] crypto/ui/ui_openssl.c: let new-line through after query in Windows path.

David Woodhouse-7
On Mon, 2016-08-01 at 10:48 +0200, Andy Polyakov wrote:
> Originally new-line was suppressed, because double new-line was
> observed under wine. But it appears rather to be a wine bug,
> because on real Windows new-line is much needed.
>
> Reviewed-by: Richard Levitte <[hidden email]>

Hm, this commit comment needs an explicit reference to the mentioned
bug in bugs.winehq.org.

I can't find it. Is it related to 
https://bugs.winehq.org/show_bug.cgi?id=27229 ?

--
David Woodhouse                            Open Source Technology Centre
[hidden email]                              Intel Corporation
--
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

smime.p7s (7K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] crypto/ui/ui_openssl.c: let new-line through after query in Windows path.

Andy Polyakov-2
>> Originally new-line was suppressed, because double new-line was
>> observed under wine. But it appears rather to be a wine bug,
>> because on real Windows new-line is much needed.
>>
>> Reviewed-by: Richard Levitte <[hidden email]>
>
> Hm, this commit comment needs an explicit reference to the mentioned
> bug in bugs.winehq.org.
>
> I can't find it. Is it related to
> https://bugs.winehq.org/show_bug.cgi?id=27229 ?

Well, the commit message is based on empirical findings. I mean it
simply reflects the fact that code was originally debugged under wine,
but then it was found that on actual Windows console prompts appear on
the same line. And since we have to accept that Windows is right,
workaround for double new-line under wine was disengaged.

--
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev