Re: [CVS] OpenSSL: OpenSSL_0_9_8-stable: openssl/crypto/pqueue/ pq_compat....

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [CVS] OpenSSL: OpenSSL_0_9_8-stable: openssl/crypto/pqueue/ pq_compat....

Brian Havard
There's a few other places where VMS is specifically tested for related to
this that probably should also be changed.

IE ./ssl/d1_pkt.c:139,1456,1741
   ./ssl/d1_pkt.c:135
   ./crypto/pqueue/pqueue.c:202

Currently, without BN_LLONG defined, I get this:
./ssl/d1_pkt.c: In function `dtls1_record_replay_check':
./ssl/d1_pkt.c:1457: invalid initializer



On Mon,  6 Jun 2005 00:43:09 +0200 (CEST), Richard Levitte wrote:

>  OpenSSL CVS Repository
>  http://cvs.openssl.org/
>  ____________________________________________________________________________
>
>  Server: cvs.openssl.org                  Name:   Richard Levitte
>  Root:   /v/openssl/cvs                   Email:  [hidden email]
>  Module: openssl                          Date:   06-Jun-2005 00:43:09
>  Branch: OpenSSL_0_9_8-stable             Handle: 2005060523430800
>
>  Modified files:           (Branch: OpenSSL_0_9_8-stable)
>    openssl/crypto/pqueue   pq_compat.h
>
>  Log:
>    Change pq_compat.h to trust the macros defined by bn.h a bit more, and thereby
>    provide better generic support for environments that do not have 64-bit
>    integers.  Among others, this should solve PR 1086
>
>  Summary:
>    Revision    Changes     Path
>    1.1.2.2     +5  -3      openssl/crypto/pqueue/pq_compat.h
>  ____________________________________________________________________________
>
>  patch -p0 <<'@@ .'
>  Index: openssl/crypto/pqueue/pq_compat.h
>  ============================================================================
>  $ cvs diff -u -r1.1.2.1 -r1.1.2.2 pq_compat.h
>  --- openssl/crypto/pqueue/pq_compat.h 30 May 2005 22:34:27 -0000 1.1.2.1
>  +++ openssl/crypto/pqueue/pq_compat.h 5 Jun 2005 22:43:08 -0000 1.1.2.2
>  @@ -63,14 +63,16 @@
>   /*
>    * The purpose of this header file is for supporting 64-bit integer
>    * manipulation on 32-bit (and lower) machines.  Currently the only
>  - * such environment is VMS.  Other environments that do not natively
>  - * support 64-bit integers can safely use the code developed for VMS.
>  + * such environment is VMS, Utrix and those with smaller default integer
>  + * sizes than 32 bits.  For all such environment, we fall back to using
>  + * BIGNUM.  We may need to fine tune the conditions for systems that
>  + * are incorrectly configured.
>    *
>    * The only clients of this code are (1) pqueue for priority, and
>    * (2) DTLS, for sequence number manipulation.
>    */
>  
>  -#if defined(OPENSSL_SYS_VMS) || defined(VMS_TEST)
>  +#if (defined(THIRTY_TWO_BIT) && !defined(BN_LLONG)) || defined(SIXTEEN_BIT) || defined(EIGHT_BIT)
>  
>   #define PQ_64BIT     BIGNUM
>   #define PQ_64BIT_CTX BN_CTX
>  @@ .

--
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  [hidden email]  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [CVS] OpenSSL: OpenSSL_0_9_8-stable: openssl/crypto/pqueue/ pq_compat....

Richard Levitte - VMS Whacker
In message <[hidden email]> on Mon, 06 Jun 2005 09:39:51 +1000 (EST), "Brian Havard" <[hidden email]> said:

brianh> There's a few other places where VMS is specifically tested for related to
brianh> this that probably should also be changed.
brianh>
brianh> IE ./ssl/d1_pkt.c:139,1456,1741
brianh>    ./ssl/d1_pkt.c:135
brianh>    ./crypto/pqueue/pqueue.c:202
brianh>
brianh> Currently, without BN_LLONG defined, I get this:
brianh> ./ssl/d1_pkt.c: In function `dtls1_record_replay_check':
brianh> ./ssl/d1_pkt.c:1457: invalid initializer

Actually, as it is, I think those won't need to have any special tests
any more, since all cases when there is no 64-bit integer provided by
the compiler (as far as we know), BIGNUMs are used instead...

I'll try that.

Thanks for the notification.

Cheers,
Richard

-----
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.

--
Richard Levitte                         [hidden email]
                                        http://richard.levitte.org/

"When I became a man I put away childish things, including
 the fear of childishness and the desire to be very grown up."
                                                -- C.S. Lewis
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [hidden email]
Automated List Manager                           [hidden email]