DSO's on Soalris

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

DSO's on Soalris

Erik Forsberg-11

after the recent changes that build engines like foo.so, I suppose
it was forgotten to update Makefile.shared for Solaris platforms.

link_dso.solaris:
        @ if $(DETECT_GNU_LD); then \
                $(DO_GNU_DSO); \
        else \
                $(CALC_VERSIONS); \
                SHLIB=lib$(LIBNAME).so; \
                SHLIB_SUFFIX=; \
                ALLSYMSFLAGS=""; \
                NOALLSYMSFLAGS=""; \
                SHAREDFLAGS="$(CFLAGS) $(SHARED_LDFLAGS) -h $$SHLIB$$SHLIB_SOVER$$SHLIB_SUFFIX -Wl,-Bsymbolic"; \
        fi; \
        $(LINK_SO_DSO)

I removed the lib prefix from SHLIB in order to pass all the tests
that tries to load the ossltest engine.

I assume that was the decision, right ?
--
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev
Reply | Threaded
Open this post in threaded view
|

Re: DSO's on Soalris

Richard Levitte - VMS Whacker-2
In message <[hidden email]> on Tue, 23 Feb 2016 16:36:34 -0800, "Erik Forsberg" <[hidden email]> said:

erik>
erik> after the recent changes that build engines like foo.so, I suppose
erik> it was forgotten to update Makefile.shared for Solaris platforms.
erik>
erik> link_dso.solaris:
erik>         @ if $(DETECT_GNU_LD); then \
erik>                 $(DO_GNU_DSO); \
erik>         else \
erik>                 $(CALC_VERSIONS); \
erik>                 SHLIB=lib$(LIBNAME).so; \
erik>                 SHLIB_SUFFIX=; \
erik>                 ALLSYMSFLAGS=""; \
erik>                 NOALLSYMSFLAGS=""; \
erik>                 SHAREDFLAGS="$(CFLAGS) $(SHARED_LDFLAGS) -h $$SHLIB$$SHLIB_SOVER$$SHLIB_SUFFIX -Wl,-Bsymbolic"; \
erik>         fi; \
erik>         $(LINK_SO_DSO)
erik>
erik> I removed the lib prefix from SHLIB in order to pass all the tests
erik> that tries to load the ossltest engine.
erik>
erik> I assume that was the decision, right ?

Yes, that's exactly the idea.  This commit message explains the
reasoning (I hope):

    commit 9ee0ed3de66678a15db126d10b3e4226e835b8f5
    Author: Richard Levitte <[hidden email]>
    Date:   Mon Feb 15 18:29:09 2016 +0100
   
        Big rename fest of engine DSO names, from libFOO.so to FOO.so
       
        The engine DSOs were named as if they were shared libraries, and could
        end up having all sorts of fancy names:
       
          Cygwin: cygFOO.dll
          Mingw:  FOOeay32.dll
          Unix:   libFOO.so / libFOO.sl / libFOO.dylib / ...
       
        This may be confusing, since they look like libraries one should link
        with at link time, when they're just DSOs.
       
        It's therefore time to rename them, and do it consistently on all
        platforms:
       
          Cygwin & Mingw: FOO.dll
          Unix:           FOO.{so,sl,dylib,...}
       
        Interestingly enough, the MSVC and VMS builds always did it this way.
       
        Reviewed-by: Andy Polyakov <[hidden email]>


Thanks for notifying!

Cheers,
Richard

--
Richard Levitte         [hidden email]
OpenSSL Project         http://www.openssl.org/~levitte/
--
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev